New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change value of "CI_COMMIT_BRANCH" for pulls to source branch #3560
Comments
If I understand you correctly that's intended. From docs about the env var:
|
But it is quite counter-intuitive that a non-main branch runs with I think the filter should be respected.
|
And what's the branch if it's a PR from a fork? This is also described in the docs: https://woodpecker-ci.org/docs/usage/workflow-syntax#branch
|
Thank you, but it is just counter-intuitive at first glance .... |
Might actually make a bit more sense to have |
Should I reopen this issue? |
Sure if that's a thing you would like to be changed. |
I can see there could also be breaking changes in 2.x, eg: Use map on all environment keys in our config #3500 (comment) So is it possible to take this breaking change in 2.5.x ? |
How, did I removed that. 🤔 Sorry @qwerty287 that wasn't on purpose. The comment was basically:
This should not be a breaking change and might be a bug, if so we should open a new issue.
As it is a breaking change, we can only change that in version 3.0 |
OK, I managed to figure it out .... I guess it is the changed behavior of handling dots For example: ES 7 documents use "environment: node.name=..." https://www.elastic.co/guide/en/elasticsearch/reference/7.17/docker.html . These environments don't work for the latest. |
pull_request_sync
Describe the bug
Somewhat related to " PR triggers the CI twice #2888 ".
To reproduce:
main
branch:new-branch
based on main and open a PR on Giteanew-branch
branchpull_request_sync
event for the PR branchnew-branch
, it still runs it and considers it asmain
branchSystem Info
server & client: 2.4.1
Additional context
No response
Validations
next
version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]The text was updated successfully, but these errors were encountered: