Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with space password #28774

Open
khryshchuk opened this issue Jan 11, 2021 · 5 comments · May be fixed by #47217
Open

Bug with space password #28774

khryshchuk opened this issue Jan 11, 2021 · 5 comments · May be fixed by #47217
Labels
focus: my account Issues related to my account page. plugin: woocommerce Issues related to the WooCommerce Core plugin. priority: normal The issue/PR is of normal priority—not many people are affected or there’s a workaround, etc. team: Proton type: bug The issue is a confirmed bug.

Comments

@khryshchuk
Copy link

khryshchuk commented Jan 11, 2021

Description: I can change my password with space (xxx123, where x = space), but then I can not change this password to another and I get the error "Your current password is incorrect.".
How to fix this bug Video Bug

@tammullen
Copy link
Contributor

Hi @khryshchuk

Thank you for submitting the issue. However, you didn’t fill out the details of the bug report template that we ask for. Without these details, we can’t fully evaluate this issue. Please provide us with the information requested so we could take a look further.

Describe the bug
A clear and concise description of what the bug is. Please be as descriptive as possible; issues lacking detail, or for any other reason than to report a bug, may be closed without action.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Screenshots
If applicable, add screenshots to help explain your problem.

Expected behavior
A clear and concise description of what you expected to happen.

Isolating the problem (mark completed items with an [x]):

  • I have deactivated other plugins and confirmed this bug occurs when only WooCommerce plugin is active.
  • This bug happens with a default WordPress theme active, or Storefront.
  • I can reproduce this bug consistently using the steps above.

WordPress Environment

``` Copy and paste the system status report from **WooCommerce > System Status** in WordPress admin. ```

@tammullen tammullen added the needs: author feedback The issue/PR needs a response from any of the parties involved in the issue. label Jan 12, 2021
@khryshchuk
Copy link
Author

Hi @khryshchuk

Thank you for submitting the issue. However, you didn’t fill out the details of the bug report template that we ask for. Without these details, we can’t fully evaluate this issue. Please provide us with the information requested so we could take a look further.

Describe the bug
A clear and concise description of what the bug is. Please be as descriptive as possible; issues lacking detail, or for any other reason than to report a bug, may be closed without action.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'

2. Click on '....'

3. Scroll down to '....'

4. See error

Screenshots
If applicable, add screenshots to help explain your problem.

Expected behavior
A clear and concise description of what you expected to happen.

Isolating the problem (mark completed items with an [x]):

* [ ]  I have deactivated other plugins and confirmed this bug occurs when only WooCommerce plugin is active.

* [ ]  This bug happens with a default WordPress theme active, or [Storefront](https://woocommerce.com/storefront/).

* [ ]  I can reproduce this bug consistently using the steps above.

WordPress Environment
Copy and paste the system status report from **WooCommerce > System Status** in WordPress admin.

This error occurs on pure WordPress and WooCommerce.
You can set a new password 'xxx123' (where x = space), but - you dont can rechange this password again!
Also, you can set a new password with only spaces ('xxxxxx', where x = space), but - you dont can rechange this password again and can't Sign In on site!

@tammullen tammullen added needs: triage feedback Issues for which we requested feedback from the author and received it. and removed needs: author feedback The issue/PR needs a response from any of the parties involved in the issue. labels Feb 12, 2021
@juliaamosova
Copy link
Contributor

Hi @khryshchuk,

Thank you for your follow-up on this issue! Our apologies for the delayed response.

I believe passwords with spaces are not supported in WooCommerce. However, I'd like to further confirm it with the WooCommerce Core team.

I am adding the needs developer feedback label to this issue so that the Core team could take a look.

Please note it may take a few days for them to get to this issue. Thank you for your patience.

@juliaamosova juliaamosova added needs: developer feedback Issues that need feedback from one of the WooCommerce Core developers. and removed needs: triage feedback Issues for which we requested feedback from the author and received it. labels Apr 26, 2021
@jeffstieler
Copy link
Contributor

I was able to reproduce this. We do support logging in with a space-prefixed password, so this is indeed a bug. We likely just need to remove the trimming logic from the change password form.

@jeffstieler jeffstieler added priority: normal The issue/PR is of normal priority—not many people are affected or there’s a workaround, etc. type: bug The issue is a confirmed bug. and removed needs: developer feedback Issues that need feedback from one of the WooCommerce Core developers. labels Nov 17, 2021
@ObliviousHarmony ObliviousHarmony added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Feb 21, 2022
@rrennick rrennick added focus: my account Issues related to my account page. team: Proton labels Nov 24, 2023
79mplus-admin added a commit to 79mplus-admin/woocommerce that referenced this issue May 7, 2024
@79mplus-admin
Copy link
Contributor

Although WordPress allows leading spaces in the password, it trims them before saving to the database. It also trims the password during authentication. WooCommerce should similarly trim the old password before verifying it during the reset process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: my account Issues related to my account page. plugin: woocommerce Issues related to the WooCommerce Core plugin. priority: normal The issue/PR is of normal priority—not many people are affected or there’s a workaround, etc. team: Proton type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants