Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The upsteam package pywin32 latest version 226 has an issue #48

Closed
rayluo opened this issue Nov 11, 2019 · 3 comments
Closed

The upsteam package pywin32 latest version 226 has an issue #48

rayluo opened this issue Nov 11, 2019 · 3 comments

Comments

@rayluo
Copy link
Contributor

rayluo commented Nov 11, 2019 •
edited

Hi Rick,

Thanks for your work on PortALocker!

Its upsteam package pywin32's latest version 226 has an issue
mhammond/pywin32#1439

which has ripple effects in all the downstream packages, including popular Microsoft Azure SDK package Azure/azure-sdk-for-python#8573

As the direct dependent of pywin32, would you consider to issue a temporary patch to pin pywin32<=225?

CC: @chlowell
@wolph wolph closed this as completed in dcda0ec Nov 11, 2019
@wolph
Copy link
Owner

wolph commented Nov 11, 2019

I'll do you one better, I've blacklisted the 226 release so a newer version will be installed automatically not never 226 :)

@rayluo
Copy link
Contributor Author

rayluo commented Nov 11, 2019

Thanks Rick (@wolph ) for the super fast response! It would be great if you release this soon and then leave a message here so that @chlowell and I would know how to guide our end users.

@rayluo rayluo mentioned this issue Nov 11, 2019
Closed
wolph added a commit that referenced this issue Nov 12, 2019
@wolph
Merge tag 'v1.5.2' into develop
e5e7d76 
Aded workaround for broken pywin32 226 release. Fixes #48 v1.5.2

# gpg: Signature made Tue Nov 12 01:24:11 2019 CET
# gpg:                using RSA key 149325FD15904E9C4EB89E95E81444E9CE1F695D
# gpg: Good signature from "Rick van Hattem <wolph@wol.ph>" [ultimate]
# gpg:                 aka "[jpeg image of size 9662]" [ultimate]
@wolph
Copy link
Owner

wolph commented Nov 12, 2019

@rayluo it's on pypi now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wolph @rayluo