New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade PDF.js above v2.0.305 #180

Closed

wojtekmaj opened this issue Apr 1, 2018 · 0 comments

Assignees

Labels

Milestone

Owner

wojtekmaj commented Apr 1, 2018

In version following v2.0.305 there were several changes introduced

PDFJS object was removed
disableWorker was deprecated

This forces us to make several changes to the code. Mainly:

replace setOptions with passing options to getDocument
rewrite the code not to use PDFJS object, but default import instead
get rid of entry file with reduced functionality - disabled workers and all the mentions of it in the documentation
update tests to somehow support JSDom while still having workers disabled (discussed on getDocument hangs in Jest/JSDom environment mozilla/pdf.js#9579)

wojtekmaj added the enhancement label

wojtekmaj added this to the 4.0.0 milestone

wojtekmaj self-assigned this

wojtekmaj mentioned this issue

Update the code to PDF.js larger than 2.0.305 #181

Merged

wojtekmaj closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment