Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

entry.noworker doesn't work because of pdfjs-dist update #149

Closed
Kerumen opened this issue Feb 5, 2018 · 3 comments
Closed

entry.noworker doesn't work because of pdfjs-dist update #149

Kerumen opened this issue Feb 5, 2018 · 3 comments
Labels
bug Something isn't working

Comments

@Kerumen
Copy link
Collaborator

Kerumen commented Feb 5, 2018

Since the version v2.0.310, the file pdf.combined.js in not present in the build anymore. Hence, the entry.noworker doesn't work.

They removed this entry in this PR.
I don't understand why but as a temporary solution to get this lib working you can pin the dependency of pdfjs-dist to 2.0.305.

Kerumen added a commit to Kerumen/react-pdf that referenced this issue Feb 5, 2018
@wojtekmaj wojtekmaj added the bug Something isn't working label Feb 5, 2018
wojtekmaj pushed a commit that referenced this issue Feb 5, 2018
@wojtekmaj
Copy link
Owner

wojtekmaj commented Feb 5, 2018

[x] Fix on 3.x branch
[x] Cherry pick to 2.x branch
[x] Automatic testing
[x] Manual sanity checks
[x] Release 2.5.3 hotfix
[x] Release 3.0.0-alpha.4 hotfix

@Kerumen
Copy link
Collaborator Author

Kerumen commented Feb 5, 2018

@wojtekmaj I'm installing this version in my project, will keep you updated.

@Kerumen
Copy link
Collaborator Author

Kerumen commented Feb 5, 2018

@wojtekmaj It works fine! Thanks for the quick publish :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants