Skip to content
This repository has been archived by the owner on Jan 2, 2023. It is now read-only.

qt submodule needs updating #5277

Open
innovara opened this issue Nov 30, 2022 · 2 comments
Open

qt submodule needs updating #5277

innovara opened this issue Nov 30, 2022 · 2 comments

Comments

@innovara
Copy link

I know that according to #5160 this project is no longer maintained however this is an effortless fix.

Currently the qt submodule is on commit cb88757 which doesn't include subsequent commits that fixed issues with gcc 9+.

So when you do:

git clone --recursive https://github.com/wkhtmltopdf/wkhtmltopdf.git

you get a version that doesn't compile with gcc 9+, until you do:

git submodule update --recursive --remote

I discovered this using wkhtmltopdf/packaging to build a package for Fedora 37 which I eventually managed to do for aarch64 and x86_64. I will open a PR with my work in due course.

@innovara
Copy link
Author

For anyone interested, this is the PR that adds Fedora 36 and 37 build targets: wkhtmltopdf/packaging#135

@ashkulz
Copy link
Member

ashkulz commented Dec 28, 2022

@innovara you're right, I ported them to the 0.12.6.x branch but not to master 🙈

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants