Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Regression RN 0.73 - onDropViewInstance not called anymore, View not cleaned up #7852

Open
1 task done
bvonheid opened this issue Feb 21, 2024 · 0 comments
Open
1 task done

Comments

@bvonheid
Copy link

What happened?

With the update to RN 0.73 the onDropViewInstance of ViewManager is not called anymore when a screen is popped from the stack.
As stated here for the onDropViewInstance:

Called when view is detached from view hierarchy and allows for some additional cleanup by the ViewManager subclass.

What was the expected behaviour?

onDropViewInstance should be called when a view is popped from the stack.

Was it tested on latest react-native-navigation?

  • I have tested this issue on the latest react-native-navigation release and it still reproduces.

Help us reproduce this issue!

You can reproduce the error in the playground app:

  1. Run 7.38.1 on Android
  2. Attach a Debugger to the App
  3. Set a Breakpoint in the com/facebook/react/uimanager/ViewManager.class file in the onDropViewInstance Method
  4. Click in Layout tab on Stack -> Push -> Pop
  5. => After the Pop onDropViewInstance should be called, but it isn't

With the same steps with 7.37.2 onDropViewInstance is called.

In what environment did this happen?

React Native Navigation version: -
React Native version: 0.73
Has Fabric (React Native's new rendering system) enabled: no
Node version: -
Device model: -
Android version: -

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant