Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select options are not centrally aligned #1552

Open
1 task
jermanuts opened this issue Feb 23, 2024 · 2 comments
Open
1 task

Select options are not centrally aligned #1552

jermanuts opened this issue Feb 23, 2024 · 2 comments

Comments

@jermanuts
Copy link
Contributor

What version of starlight are you using?

0.19.1

What version of astro are you using?

4.4.4

What package manager are you using?

pnpm

What operating system are you using?

Windows

What browser are you using?

Brave

Describe the Bug

This is how they look

image

They should look like that

image

Same with the language selection box

image
image

Link to Minimal Reproducible Example

https://github.com/withastro/starlight

Participation

  • I am willing to submit a pull request for this issue.
@at-the-vr
Copy link
Contributor

at-the-vr commented Feb 24, 2024

this feels like a subjective opinion and less of a bug (both look fine to me). Could you share a concrete proof in form of a reference from MDN or a trusted article talking that your suggestions are applicable?

@rgilsimoes
Copy link
Contributor

I would agree with a little bit more margin to the left side of the label icon.
That's used by Material UI for example:
https://m2.material.io/components/menus#exposed-dropdown-menu

Here's my take on the subject:
image
image
image

Let me know if this ok and I can submit it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants