Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

View Transitions Script Behavior #8000

Open
OliverSpeir opened this issue Apr 24, 2024 · 1 comment
Open

View Transitions Script Behavior #8000

OliverSpeir opened this issue Apr 24, 2024 · 1 comment
Labels
help wanted Issues looking for someone to run with them! improve documentation Enhance existing documentation (e.g. add an example, improve description)

Comments

@OliverSpeir
Copy link
Contributor

馃搵 Explain your issue

The /view-transitions/#script-re-execution section I think is not correctly directing users to the truly happy path. Ideally for most users a lifecycle event would be listened for in order to deal with script rexecution. data-astro-rerun should only be used when necessary, after considering using a lifecycle event.

Commonly users might reach for data-astro-rerun when in fact they want to only run a callback on certain pages. This section could help users stay on the happy path by giving an example of checking if an element is on the page before running a function related to it like this example.

@sarah11918
Copy link
Member

We always want to keep our users on a happy path!

Is anyone interested in taking a closer look at docs and suggesting some improvements?

@sarah11918 sarah11918 added improve documentation Enhance existing documentation (e.g. add an example, improve description) help wanted Issues looking for someone to run with them! labels May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issues looking for someone to run with them! improve documentation Enhance existing documentation (e.g. add an example, improve description)
Projects
None yet
Development

No branches or pull requests

2 participants