Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning for ReactDOM.renderToStaticNodeStream used in @astrojs/react/server.js #10921

Closed
1 task
corneliusroemer opened this issue May 1, 2024 · 1 comment
Labels
needs triage Issue needs to be triaged

Comments

@corneliusroemer
Copy link

Astro Info

Astro                    v4.7.0
Node                     v21.7.1
System                   macOS (arm64)
Package Manager          npm
Output                   server
Adapter                  @astrojs/node
Integrations             @astrojs/tailwind
                         @astrojs/react
                         @astrojs/mdx

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

When using react 18.3.0, I get deprecation warnings caused by @astrojs/react's use of ReactDOM.renderToStaticNodeStream:

Warning: ReactDOMServer.renderToStaticNodeStream() is deprecated.  \
Use ReactDOMServer.renderToPipeableStream() and wait to `pipe` until the `onAllReady` callback has been called instead.

What's the expected result?

No use of deprecated APIs

While this is only a (very noisy) warning at the moment, it will become an error with React 19.

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-v6fatj?file=package.json

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label May 1, 2024
@corneliusroemer
Copy link
Author

Duplicate of #10899 (already fixed but not yet released)

@corneliusroemer corneliusroemer closed this as not planned Won't fix, can't repro, duplicate, stale May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

1 participant