Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification regarding generators #44

Open
cognivore opened this issue Oct 11, 2021 · 1 comment
Open

Clarification regarding generators #44

cognivore opened this issue Oct 11, 2021 · 1 comment

Comments

@cognivore
Copy link

Oddly enough, both generators in the documentations and the generator I've seen in Maybe are ignoring their argument and use Enum.random().

This seems to be an anti-pattern in property-based testing because it relies on reproducibility of a random test that caught an error.

I assume that the underlying plumbing somehow sets a global seed for Enum.random(), perhaps mix test even does it itself (hence "Randomized with seed NNN" messages at the end of the tests), but in my opinion a clarification is required here.

@github-actions
Copy link

Thank you for submitting an issue! It means a lot that you took the time -- it helps us be better 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant