Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Make File transport create log dir if it doesn't exist #1465

Open
DABH opened this issue Sep 12, 2018 · 1 comment
Open
Labels
Feature Request Request for new functionality to support use cases not already covered

Comments

@DABH
Copy link
Contributor

DABH commented Sep 12, 2018

What's the feature?

I've seen several times people confused their log files don't appear (e.g. #875) because the dir into which they want to write files doesn't exist. So I think we should allow winston to automatically create the log dir -- either as an option to the File transport, or even as the default behavior (with an option to disable). @indexzero can advise whether it should be a default or not.

What problem is the feature intended to solve?

Multiple GitHub issues for winston about this, it trips up users

Is this a feature you're prepared to implement, with support from us?

@JamesTheHacker has indicated interest in creating a PR for this! 🚀

@DABH DABH added the Feature Request Request for new functionality to support use cases not already covered label Sep 12, 2018
@adoyle-h
Copy link
Contributor

@DABH I have committed a PR to resolve this issue. Please review the codes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Request for new functionality to support use cases not already covered
Projects
None yet
Development

No branches or pull requests

2 participants