Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$ in fast wrap to always insert end pair at the end? (and a more flexible hint system idea) #408

Open
bew opened this issue Oct 15, 2023 · 7 comments
Labels
enhancement New feature or request pinned

Comments

@bew
Copy link
Contributor

bew commented Oct 15, 2023

it is something I mentioned in #398, but was not covered by any discussion, re-posting here to trigger potential discussion

Is your feature request related to a problem? Please describe.
When I use fast wrap feature, using the end-of-line $ hint can have 2 different behavior based on the last char of the line:

  • if it matches the hint pattern, the plugin will ask if the end pair of fast wrap should be put before/after last char
  • if it does NOT match the pattern, the plugin will always put end par at the very end

Describe the solution you'd like
I like my tools to be easily deterministic, without too much guessing and differing behavior.
👉 I want that when I wrap to the end of line with $ hint, it always put the end pair at the very end, without asking to put it before/after the last char.
To that end, I think the $ hint should be after the last char to show it'll always put end pair at the very end.
If the line ends with a char matching the pattern there would be another hint for it, that allows to put the end pair before/after.

Even more flexibility could be offered by a function that returns hint data, and if the matching hint has multiple positions, show the 2nd layer of hint positioning, or just insert it directly otherwise.

Describe alternatives you've considered
Always second guessing myself and checking the last char, remembering the pattern and double checking what to do.

@bew bew added the enhancement New feature or request label Oct 15, 2023
@windwp
Copy link
Owner

windwp commented Oct 17, 2023

I agree on some case you don't need to typing 2 key . PR is welcome 🤟

Copy link

stale bot commented Dec 16, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Dec 16, 2023
@bew
Copy link
Contributor Author

bew commented Dec 16, 2023

It's still in my radar 🙏

@stale stale bot removed the wontfix This will not be worked on label Dec 16, 2023
Copy link

stale bot commented Feb 14, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Feb 14, 2024
@bew
Copy link
Contributor Author

bew commented Feb 14, 2024

no?

@stale stale bot removed the wontfix This will not be worked on label Feb 14, 2024
Copy link

stale bot commented Apr 14, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 14, 2024
@bew
Copy link
Contributor Author

bew commented Apr 14, 2024

I don't use neovim as often (work + other priorities), but this is still definitely important..
Next time the stale bot comes I'll probably not comment again, but I'll definitely keep it in my radar of stuff I want to fix some day.

@stale stale bot removed the wontfix This will not be worked on label Apr 14, 2024
@windwp windwp added the pinned label May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pinned
Projects
None yet
Development

No branches or pull requests

2 participants