New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

problem in velo_points_2_pano funciton #13

Open

AIGC-newbee opened this issue Jun 12, 2023 · 0 comments

AIGC-newbee commented Jun 12, 2023 •

edited

I found something illogical in function velo_points_2_pano of Convert_Velo_2_Pano_detail.ipynb;

def velo_points_2_pano(points, v_res, h_res, v_fov, h_fov, depth=False):
    # Projecting to 2D
    x = points[:, 0]
    y = points[:, 1]
    z = points[:, 2]
    dist = np.sqrt(x ** 2 + y ** 2 + z ** 2)

    # project point cloud to 2D point map
    y_img = -(np.arctan2(z, dist) / (v_res * (np.pi / 180)))

Should dist = np.sqrt(x ** 2 + y ** 2) rather than dist = np.sqrt(x ** 2 + y ** 2 + z ** 2)? I discussed with ChatGPT4,0 who also agrees with me.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment