Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tests in workflows #64

Open
joaodasilva opened this issue Jan 16, 2022 · 4 comments
Open

Enable tests in workflows #64

joaodasilva opened this issue Jan 16, 2022 · 4 comments
Assignees
Labels

Comments

@joaodasilva
Copy link
Contributor

6a09576 enabled running the tests in workflows but they fail to start on all VMs.

The Windows builder hangs on test startup:
https://github.com/windowjs/windowjs/runs/4834049064

The macOS builder crashes in glfwInit:
https://github.com/windowjs/windowjs/runs/4834049290

The Linux builder asserts on glfwInit failing:
https://github.com/windowjs/windowjs/runs/4834077103

Also tried using Xvfb on the Linux builder but got the same result.

Apparently GitHub actions don't support applications that open native windows. This needs further investigation, and possibly an alternative to run tests in PRs.

@joaodasilva joaodasilva self-assigned this Jan 16, 2022
@joaodasilva
Copy link
Contributor Author

The Linux build is running the tests now, using xvfb-run.

@joaodasilva
Copy link
Contributor Author

The Windows runners on GitHub Actions don't have a GL driver; glfwCreateWindow fails with "WGL: The driver does not appear to support OpenGL".

This will require integrating ANGLE to use Direct3D.

@joaodasilva
Copy link
Contributor Author

The macOS runners crash inside GLFW, in cocoa_monitor.m getFallbackRefreshRate, while calling IOServiceGetMatchingServices for IOFramebuffer; very unclear why this happens. Bypassing that then fails later:

glfwCreateWindow failed (65545): NSGL: Failed to find a suitable pixel format

Try this again later with ANGLE too, and try to use the Metal backend.

@joaodasilva
Copy link
Contributor Author

Windows is fixed after the migration to ANGLE.

Running on macOS is still failing for the same reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant