bug: Draft got lost, when having deployed and draft version in edit view in parallel

[wasnertobias]

Describe the bug

Had the deployed version in edit mode (as the non-edit mode shows too less detail) and a draft version concurrently in another browser Tab.

After I made changes to a subflow of the draft (Input Data changed) I had to relead the draft version, otherwise Windmill does not recognize the change Input Data for the subflow. So before I did reload the draft version I clicked on "Save Draft". It told me that there are no current changes, it offered me to "save anyway", which I did not find a reason to click on. So I reloaded.

Badumm, the draft is gone, very nice. It just loads the deployed version without the usual pop-up in the upper right corner to load the deployed version.

To reproduce

Described above

Expected behavior

Draft is not deleted for no aparent reason.

Screenshots

No response

Browser information

Chromium Version 124.0.6367.92

Application version

EE v1.320.3-4-g39e1ea3d5

Additional Context

No response

[rubenfiszel]

yes the issue is because we use localStorage which is across tabs. We need to migrate to use anchor to persist local changes or use other means to work well with multiple tabs on the same flow

[wasnertobias]

It is not even separated between workspaces, as I just found out. I edited something on PROD due to the following:

• bug: No permission to edit, but no error message on save #3677 (comment)
• feature: Clearly mark PROD workspace over STAGING in edit view #3647

Then I noticed and switched to STAGING workspace: Now it asks via toast whether I want to keep my changes, although I never made any in STAGING.