Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CaptureAndSaveAsync doesn't always return the path #13

Open
AltereD opened this issue May 21, 2020 · 0 comments
Open

CaptureAndSaveAsync doesn't always return the path #13

AltereD opened this issue May 21, 2020 · 0 comments

Comments

@AltereD
Copy link

AltereD commented May 21, 2020

Hi,

Thank you for the plugin first of all.

The line below appears problematic to me as it will return an exception message instead of a file path and the caller won't even be aware of that.

I would suggest not catching at all or rethrowing or even returning null to prevent a breaking change and keeping things simple.

Otherwise a new data structure could be used as well, such as a class that contains the path to the image and a status that tells if the capture was successful or not. But that would be a breaking change.

The same problem is present on iOS too:

result = nsError.LocalizedDescription;

I am willing to contribute for a fix.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant