Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow system theme #67

Open
Jnss98b opened this issue May 10, 2022 · 8 comments
Open

Follow system theme #67

Jnss98b opened this issue May 10, 2022 · 8 comments
Labels
enhancement New feature or request

Comments

@Jnss98b
Copy link

Jnss98b commented May 10, 2022

πŸ“ Provide a description of the new feature

Basically use the light mode when system is in light mode and dark when the system is in dark mode

βž• Additional Information

No response

@Jnss98b Jnss98b added the enhancement New feature or request label May 10, 2022
@rlaphoenix
Copy link
Collaborator

I don't know if this can be done with spicetify, but even if it can it may not be wanted by the user. They may specifically want an alternate theme to their system.

@Jnss98b
Copy link
Author

Jnss98b commented May 10, 2022

You should make it toggleable then. And yes it's possible bc this spicetify theme does it and it makes it toggleable too: https://github.com/JulienMaille/dribbblish-dynamic-theme#follow-system-darklight-theme-powershell

@rlaphoenix
Copy link
Collaborator

That method does seem to require patching of the Spotify exe which will complicate things, especially if users do not want to modify the exe.

However, more problematic is the Fluent light theme is very experimental and doesn't work very well even on supported Spotify versions. It will need to be worked on before this is implemented.

@Jnss98b
Copy link
Author

Jnss98b commented May 10, 2022

I'm glad it's considered anyway

@nimsandu
Copy link

is this feature really useful?
i mean user can change config to light theme using shell
and that process is a one time process
making things complicated will kill the calmness of fluent designing system

special note- @williamckha is a great creator i respect him and even im using his theme as my themes base
i still following his principles

@Jnss98b
Copy link
Author

Jnss98b commented Jul 14, 2022

It is useful if you have auto dark mode. It's gonna get tiring really fast to open up the terminal twice a day every day to change the theme

@nimsandu
Copy link

@Jnss98b Yah that makes sense
But this should go smoothly as a step by step process

First we have to develop light theme more fluent and less buggy

@Jnss98b
Copy link
Author

Jnss98b commented Jul 14, 2022

Yeah I get that. There's no rush at all. I was just answering @nimsandu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants