Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of Upgrade button and any other ad-blocking shouldn't be done by Fluent #50

Open
rlaphoenix opened this issue Feb 25, 2022 · 4 comments

Comments

@rlaphoenix
Copy link
Collaborator

rlaphoenix commented Feb 25, 2022

By default, for legal reasons, it shouldn't be done. However, there's also UX reasons not to do so. Some people might want to have that upgrade button if their Premium runs out.

If the user then still doesn't want the upgrade button, they could either remove it via Spicetify Marketplace -> Snippets -> Hide Upgrade Button, or remove it via BlockTheSpot (which those users will most likely be installing anyway).

It can also be done (and done better) with https://github.com/Daksh777/SpotifyNoPremium

@nin0-dev
Copy link

BlockTheSpot doesn't work anymore.
But I agree with you.
This theme shouldn't do the adblocking.

@bathtimethiago
Copy link

@rlaphoenix
Copy link
Collaborator Author

https://github.com/bathtimethiago/spicetify-fluent-fix

This seems to be mostly adblocking, and the purpose of this issue is to discuss the removal of all adblocking, not the addition of more or fixes to it.

@bathtimethiago
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants