Support encoding PG::Interval params
#283
Conversation
| @@ -68,6 +68,11 @@ module PQ | |||
| text string | |||
| end | |||
|
|
|||
| def self.encode(val : PG::Interval) | |||
| # https://www.postgresql.org/docs/current/datatype-datetime.html#DATATYPE-INTERVAL-INPUT | |||
| text "#{val.months} months #{val.days} days #{val.microseconds} microseconds" | |||
There was a problem hiding this comment.
Alternatively, could move this logic into PG::Interval#to_s(io)?
There was a problem hiding this comment.
How come no minutes or seconds? If I had something like this
db.exec("INSERT INTO events (recurring_interval) VALUES (?)", args: 5.minutes)Wouldn't this insert 0 months 0 days 0 microseconds? Or is that unrelated to what this PR is for?
There was a problem hiding this comment.
I wondered about this too. But as far as I can tell the PG::Interval type only exposes the three properties I used.
However your example would work just fine as Time::Span also works for inserting. I could also see it making sense to handle the opposite case of #272 where we allow reading INTERVAL PG types into a Time::Span. Then for most use cases you could use that, but if you really need the exact same behavior/precision you could use PG::Interval.
Resolves #272.
I opted to encode the
PG::Intervalusing the textual representation of a PG interval type, primarily to just have the most accuracy.