Enhance and simplify logging guide #541
Conversation
|
@jamezp, any objections to merging this? |
| log.trace("called method with: " + name); | ||
| } | ||
|
|
||
| log.trace("called method with: {}", name); |
There was a problem hiding this comment.
This isn't quite correct. For a format like this it needs to be tracev. However, I'd suggest using:
log.tracef("called method: %s", name);
|
@jamezp I agree it's better you open a separate PR to adjust the content. |
Let me know what you think about #542 @hpehl. The plugin configuration could remove. However, it won't work out of the box the way that is currently shown. We might need a more uniform approach in general to that part of the message though. |
|
I've put the 'hold' label on this due to the discussion around #542. The label is just to make the fact there's an ongoing 'blocking' discussion more visible when looking at the PR queue. |
Fixes #540