From 493083e288a1139ab144379928fe5093e25fa4b6 Mon Sep 17 00:00:00 2001 From: Farah Juma Date: Thu, 7 Dec 2023 14:12:46 -0500 Subject: [PATCH] [ELY-2708] Update the CONTRIBUTING.md file with information on Elytron's code review process and maintenance branches --- CONTRIBUTING.md | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 27c26b7ae87..11abb5b9076 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -95,5 +95,17 @@ When submitting a PR, please keep the following guidelines in mind: For an example of a properly formatted PR, take a look at https://github.com/wildfly-security/wildfly-elytron/pull/1532 +## Code Reviews + +All submissions, including submissions by project members, need to be reviewed by at least two WildFly Elytron committers before being merged. + +The [GitHub Pull Request Review Process](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/about-pull-request-reviews) is followed for every pull request. + +## Maintenance Branches + +If you are working on a fix that's required for a maintenance branch (e.g., a fix for the 1.15.x or 2.2.x branches), please submit +your PR directly against the relevant maintenance branch. Once approved and merged, the fix will then be forward ported to the +currently active branch. + ## Community For more information on how to get involved with WildFly Elytron, check out our [community](https://wildfly-security.github.io/wildfly-elytron/community/) page.