Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TypeError for numeric values #177

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

deepikap1
Copy link

@gwhenne, please review this pull request. Should resolve #176 .

@gwhenne
Copy link

gwhenne commented Aug 22, 2018

Works correctly in my test case - thank you!

@ricordisamoa
Copy link
Contributor

According to https://api.jquery.com/data/#data-html5 you can use $this.attr( 'data-i18n' ) to retrieve the value directly as a string. However, its behavior may differ in a few cases (e.g. message keys resembling arrays, programmatic use of .data()).

@deepikap1
Copy link
Author

@ricordisamoa Should I make the changes or is my previous commit fine?

@kartikm
Copy link
Member

kartikm commented Aug 27, 2018

@deepikap1 dd1beba looks unrelated commit here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Numeric value causes TypeError
4 participants