Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an illustrative PR/issue tag #16

Open
paddymul opened this issue Apr 28, 2023 · 2 comments
Open

Add an illustrative PR/issue tag #16

paddymul opened this issue Apr 28, 2023 · 2 comments

Comments

@paddymul
Copy link
Collaborator

paddymul commented Apr 28, 2023

There have been a bunch of small issues and pull requests here are very useful for future implementers, because they contain explanation of why things work as such. Ideally this would all be in documentation, until then, can we tag them with something like "illustrative PR".

There is a lot of context necessary for someone to use ipyreact, and it is going to be rare for someone to understand all of the following

  • Traitlets quirks (only assignment - not updates to a dict, change must be present)
  • React only assignment not updates to a dict
  • Where JS errors show up in the jupyter notebook

#14
#11
#6

@paddymul
Copy link
Collaborator Author

Also I want to say, this is very impressive work by @maartenbreddels , I think this could really help increase jupyter widget creation, and build a bridge to the JS community.

If a normal frontend/JS developer comes to jupyter land to start trying to build stuff, they are confronted by a bunch of things that are new and novel to them (or reallly old like backbone.js). So they have to figure out widgets, traitlets, jupyter, possibly lumino, and lab extension packaging. Python itself is a mild hurdle compared to the rest.

This project limits that to

  • widget/react data binding boundary (where all of these PRs and Issues are digging into)
  • A very small amount of ipython magics that gives the frontend dev a much tighter OODA loop on JS changes

@maartenbreddels
Copy link
Contributor

maartenbreddels commented May 3, 2023

Thanks @paddymul ! (sorry for my late reply, just back from vacation!)

I like that! I invited you to 'triage' member of this repo. Let me know if that allows you to create labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants