Crash, unexpexted error during game, port dock without water nearby

[TorstenFunk]

After playing WL with a downloaded map for several hours, the game crashed with an error message, telling me to report it here. In short it says "Attempting to create a port dock around 264x109 without any water nearby". I can't remember what I did last in the game.

This happened for the first time.

It shouldn't happen.

Folder "crash" is empty. See screenshot for details.

No replay available.

Zip-file contains two save games:
2024-03-03T17.14.42.wgf: This was saved by the game just after I took the screenshot. Since the file size is smaller than the other, it might be corrupted.
wl_autosave_00.wgf: The last save game from before the crash happened
02 Crash.zip

• Windows 7 Pro 64bit
• Widelands Version: Widelands-Release-x64-1.2~git(7615571@master)
• Enabled Add-Ons: none

[bunnybot]

Mirrored on Codeberg as #CB4758.

[bunnybot]

Mirrored from Codeberg
On Tue Mar 05 17:50:37 CET 2024, Benedikt Straub (Nordfriese) wrote:

---

Hello and thanks for the bug report.

I have checked the savegame and map file and indeed, 264x109 is marked as a port space in the map's port_spaces data file even though no port can be built there because the field is a bit too far away from the river. I guess an AI player sent an expedition there and the field was detected as a port space.

A map is supposed to sanitize port spaces on saving so that invalid entries like this one are not reported as actual portspaces. We should not rely on maps to be valid and sanitize the portspaces again during loading a map, probably by calling Map::cleanup_port_spaces in WidelandsMapLoader::load_map_complete or even in Map::recalc_whole_map.