Add-on comments: Window didn't respond after clicking "OK"

[frankystone]

After trying to write an add-on comment and clicking OK the game hung. It was not possible to make it responsible again. In the end i had to kill the widelands process.

Close before this i watched a replay until the end. Don't know if this is related.

To reproduce
No idea. I don't want to spam comments for testing.

Expected behavior
The widelands process should always be responsible.

Version:

• OS: archlinux
• Widelands Version: 1.2~git26547 (4a72b88@master) Release
• Enabled Add-Ons: minimalistic theme, where_are_my_heroes

Additional context
The button for sending a comment should called "Send", not "OK".

[bunnybot]

Mirrored from Codeberg
On Mon Feb 19 19:04:03 CET 2024, Tóth András (tothxa) wrote:

---

In such cases you can at least get a backtrace if you use kill -11.

Did you save the console log? We should have some logging of deadlocks. Though I think a possible deadlock for the logging itself is still in master, with a fix pending in #6182.

[bunnybot]

Mirrored from Codeberg
On Mon Feb 19 19:09:55 CET 2024, ** (frankystone)* wrote:*

---

The console just said nothing:

[04:24:37.903 game] ERROR: REPLAY: End of replay (gametime: 15893792)
Getötet

Don't know why the end of replay is shown as an error...

[bunnybot]

Mirrored from Codeberg
On Mon Feb 19 20:01:51 CET 2024, Benedikt Straub (Nordfriese) wrote:

---

I checked the server logs and it shows only one comment from you, so this comment request never reached the server. This hang can't be a threading problem for a change as the main menu is single-threaded. If it's not reproducible it might be a random network package loss as addressed in #6008.

I don't want to spam comments for testing.

Alpha is up on --addons_server_port=7377 with PR https://codeberg.org/wl/wl_addons_server/pulls/84 and can be spammed freely for testing ;)

Don't know why the end of replay is shown as an error...

This should be changed from log_err_time to verb_log_info_time on occasion…

[bunnybot]

Mirrored from Codeberg
On Sun Feb 25 16:55:28 CET 2024, ** (frankystone)* wrote:*

---

Happend again yesterday.