Buttons partially hidden on building enhancement window when using larger font theme

[andy5995]

Related to #1294 and #2851

Using the 1.1~git48/98044ee@master/Debug version of WL and an add-on theme I recently uploaded through the add-ons menu, the Larger Font theme... No problems that I've seen 45 minutes into a game, except for the building enhancement window.

I was kinda wondering if there was something different about that window in the cpp source code that might account for it. If you think it's an easy fix, like matching up that code with how the other windows are created. I haven't looked at the code much yet... Most of my experience is with C not C++.

Anyway, if there won't be a fix for a while, I just thought I'd mention it in case it was important to note. If you think it might be an easy or semi-easy fix and give me a little guidance to start, I'll see what I can do.

You can see the other windows are handling the font size ok.

[Noordfrees]

The action confirmation window still uses the old-style layouting so it has a fixed size. It'll need to be converted to the new-style box layouting so it resizes itself to accommodate the size of its content.

Since the content itself is already using box layout this could be as simple as replacing the fixed-size layouting with a call set_center_panel(main_box) in the ActionConfirm constructor:

widelands/src/wui/actionconfirm.cc

Lines 167 to 169 in b21dc78

	main_box->set_size(textarea->get_w(), textarea->get_h() + button_box->get_h() + 1.5 * padding +
	(checkbox_ ? checkbox_->get_h() + padding : 0));
	set_inner_size(main_box->get_w() + 2 * padding, main_box->get_h() + 2 * padding);

However this would also mean that all variations of this window always resize themselves to their content and therefore all have different sizes. I am not sure if this desirable, or if it would be better to have a fixed horizontal and minimum vertical size with as-needed vertical size increase (which might be a bit harder).

[frankystone]

A problem might be that one has to add linebreaks manually if the width is not fixed?