Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace loading incomplete gating hierarchy #179

Open
ldrufuca opened this issue Nov 13, 2023 · 2 comments
Open

Workspace loading incomplete gating hierarchy #179

ldrufuca opened this issue Nov 13, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@ldrufuca
Copy link

Hi, thanks for the very useful package!

I recently encountered an unexpected behavior while loading a workspace instance. In particular it appears that the gating hierarchy tree is incompletely loaded.
As a comment to the workspace loading routine I found the following note:

# Incomplete group tree: The collection of group gates is not
# guaranteed to have the complete gate tree. This occurs if all
# samples have a custom gate for a particular gate tree node.

but as I went back to flowjo it appears that while some samples have 'custom' gates, most of them share the same gating hierarchy as defined for the group with no modifications.

Incidentally I realized that the missing gating subtree starts with a 'NOT' boolean gate and it is the only boolean gate in the hierarchy though I do not know whether the two facts are related.

Could someone help me understanding what is happening?

@whitews
Copy link
Owner

whitews commented Apr 2, 2024

Hi & apologies for the late response!

Would you be able to share the workspace (can be privately via email)? Or, even better, would be to attempt to replicate the issue using the 8-color data set in data/8_color_data_set.

Regards,
Scott

@whitews
Copy link
Owner

whitews commented Apr 3, 2024

OK, I created a workspace file incorporating the Boolean NOT gate and can confirm they do not get imported. These gates are implemented very differently in the XML structure and it'll take a bit to properly support them. Unfortunately, this won't make it in the upcoming 1.1 release but I'll get to it in the next one and keep this open in the meantime. Thanks for reporting this!

@whitews whitews added this to the Release version 1.2.0 milestone Apr 3, 2024
@whitews whitews added the enhancement New feature or request label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants