Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for matrix-inverted-already attribute in GatingML #131

Open
krcurtis opened this issue Oct 19, 2022 · 4 comments
Open

Support for matrix-inverted-already attribute in GatingML #131

krcurtis opened this issue Oct 19, 2022 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed on-hold Under consideration

Comments

@krcurtis
Copy link

Is your feature request related to a problem? Please describe.
FlowKit does not appear to use the matrix-inverted-already flag in GatingML

Describe the solution you'd like
It would be nice if FlowKit could use an already inverted matrix. For example, the DIVA vendor specific XML files already include a compensation matrix, but it appears to be already inverted. I'd like to use their matrix as-is without going thru a matrix inversion to avoid adding more noise.

Describe alternatives you've considered
I can invert the matrix found in DIVA vendor specific files and not use the matrix-inverted-already flag when generating GatingML files to use with FlowKit

Additional context

@whitews
Copy link
Owner

whitews commented Dec 15, 2022

Thanks for the feedback. I must have missed this option in the specification. I'll take a look at adding support for this. Any chance you can provide an example GatingML document that uses this?

-Scott

@whitews whitews added the enhancement New feature or request label Dec 15, 2022
@whitews whitews added this to the Release version 1.1.0 milestone Feb 23, 2023
@whitews whitews removed this from the Release version 1.1.0 milestone May 18, 2023
@whitews whitews added the on-hold Under consideration label May 18, 2023
@whitews
Copy link
Owner

whitews commented May 18, 2023

On-hold until I have an example GatingML file using matrix-inverted-already

@krcurtis
Copy link
Author

I'm not sure if my request is useful anymore. I guess I'd suggest closing as "won't fix" until a more compelling use case comes up

@whitews whitews added the help wanted Extra attention is needed label May 18, 2023
@whitews
Copy link
Owner

whitews commented May 18, 2023

I'm definitely open to supporting it, just need an example of a valid example Diva XML file using the matrix-inverted-already attribute, preferably with FCS files. I'll tag this as help wanted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed on-hold Under consideration
Projects
None yet
Development

No branches or pull requests

2 participants