Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Ability to select multiple tags at a time #100

Open
michaeltheshah opened this issue Aug 19, 2018 · 4 comments
Open

Feature Request: Ability to select multiple tags at a time #100

michaeltheshah opened this issue Aug 19, 2018 · 4 comments

Comments

@michaeltheshah
Copy link

Which version of the WSTagsField are you using?

3.1.0

On which platform does the issue happen?

E.g. iOS11

Are you using Carthage?

No

Are you using Cocoapods?

1.4.0

Which version of Xcode are you using?

Xcode 9.4.1

What did you do?

I'm trying to allow multiple tags to be selected. What I have tried to do is override selectTagView(_ tagView: WSTagView, animated: Bool) in order to simply toggle the selected state of the tagView, but it seems like even when removing the block to unselect all of the other tags...

tagViews.filter { $0 != tagView }.forEach { $0.selected = false onDidUnselectTagView?(self, $0) }
...they all still get unselected.

What did you expect to happen?

Multiple tags to be selected

What happened instead?

They seem to all get unselected and then the tag the user selected is shown.

@michaeltheshah
Copy link
Author

Looks like the first culprit is resignFirstResponder(). I commented out the selected = false and it allows multiple selections. Now to unselect...

@michaeltheshah
Copy link
Author

@ricardopereira Any update to this? It's been awhile

@ricardopereira
Copy link
Member

@mochat97 I have no time available to implement this. Can you fork and do the change please? I can review it. Thanks

@michaeltheshah
Copy link
Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants