Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix form to add exercises to days #1567

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix form to add exercises to days #1567

wants to merge 1 commit into from

Conversation

adrianlzt
Copy link

@adrianlzt adrianlzt commented Jan 25, 2024 •
edited

Proposed Changes

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Added yourself to AUTHORS.rst

Other questions

  • Do users need to run some commmands in their local instances due to this PR
    (e.g. database migration)? No

Adding an exercise with id > 999:

Default form:
image

After moving the slider:
image

@adrianlzt
Fix form duplication when id > 999 and localized
36df3da 
For ids higher than 999, the localization is formating the number as
1.234, or 1,234.
This format make the 'updateAllExerciseFormset' js function to fail
trying to delete the previous form:
$('#formset-base-' + exerciseId).remove()

So, each time the slider is changed, a new form is appended at the end.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changing the number of sets in custom exercises duplicate the form
1 participant
@adrianlzt