Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No slash after domain drops GET query params #532

Open
chedatomasz opened this issue Nov 8, 2023 · 0 comments
Open

No slash after domain drops GET query params #532

chedatomasz opened this issue Nov 8, 2023 · 0 comments

Comments

@chedatomasz
Copy link

chedatomasz commented Nov 8, 2023

When wrk is called on an address such as example.com?key=val, it quietly truncates to example.com/ and skips the query params.
This is different to the behaviour of other tools such as curl, which corrects example.com?key=val to example.com/?key=val.

Technically any behaviour is correct because example.com?key=val is not a valid URL - the standard allows omitting the training slash representing the empty path only when the query params are used (https://www.rfc-editor.org/rfc/rfc1738#section-3.3)

However, given the behaviour of other tools and user experience (this took a LONG time to track down), I believe either rewriting like curl or failing explicitly is vastly preferable to the current rewriting and the current behaviour should be treated as a bug.
@wg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant