Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forgit does not open in a tmux popup window if fzf tmux options are set #303

Open
5 of 10 tasks
dljsjr opened this issue May 5, 2023 · 0 comments
Open
5 of 10 tasks

Comments

@dljsjr
Copy link

dljsjr commented May 5, 2023

Check list

  • I have read through the README
  • I have the latest version of forgit
  • I have searched through the existing issues

Environment info

  • OS
    • Linux
    • Mac OS X
    • Windows
    • Others:
  • Shell
    • bash
    • zsh
    • fish

Problem / Steps to reproduce

I have FZF_TMUX=1 and FZF_TMUX_OPTS='-p60%,80%' set to be exported by my .zshrc. When those are set, the built-in FZF helpers like Alt-C, etc. will default to fzf-tmux instead of fzf. And by setting -p with a tmux version >= 3.2, it uses the popup windows instead of a split:

image

I don't know for sure what the root cause is here, but I'm guessing what's happening here is that forgit is hardcoded to use the fzf binary. It might be nice if forgit could detect FZF_TMUX or FZF_TMUX_OPTS, and if they're set it could behave like the built-in forgit extensions and default to fzf-tmux. This should be safe to do universally, as the fzf README states that fzf-tmux is smart enough to be well behaved if invoked outside of a tmux session:

It will still work even when you're not on tmux, silently ignoring -[pudlr] options, so you can invariably use fzf-tmux in your scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant