Remove confusion about SP and MP saves of hybrid campaigns having the same names

[Discontinuum]

Describe the desired feature

When a campaign is hybrid (both sp/mp), its saves mix up in the saves folder: they have the same names. If you, let's say, do the campaign with your friend(s) in the MP mode and then do it solo, start-of-scenario saves of an SP run will erase MP ones (as they are named the same way). Because of this right now having a hybdrid campaign is extremely uncomfortable, so I preferred in my hybdrid campaign to make actually two campaigns: one SP only and one MP only, that differ only by their ids and abbreviation, so saves aren't erasing each other anymore.

Maybe we can add some save name distinguisher (like "MP" suffix for mp saves) for hybrid campaigns by default

[knyghtmare]

I wonder if this is viable as a solution:

[campaign]
    #ifdef MULTIPLAYER
    id=Campaign_ID_MP
    abbrev="Campaign_MP"
    #else
    id=Campaign_ID_SP
    abbrev="Campaign"
    #endif
    type=hybrid
[/campaign]

[soliton-]

That's pretty much what they said they did as a workaround. That should not be necessary. Also we should move away from more reliance on the preprocessor.

[Discontinuum]

I made a bit different way

#define MY_CAMPAIGN TYPE ABBR
[campaign]
id=my_campaign_{TYPE}
type={TYPE}
abbrev={ABBR}
...
[/campaign]
#enddef
{MY_CAMPAIGN sp "ABBR"}
{MY_CAMPAIGN mp "ABBR MP"}

the workaround by knyghtmare seems much less reliable to me. It feels suspicious that a campaign will define itself differently depending on the preprocessor's state.

Maybe we can add an optional parameter abbrev_mp to the [campaign] tag that will apply if it's a hybrid campaign run in MP

[soliton-]

I think adding a fixed string like the "MP" you mentioned after the abbreviation is enough. If someone wants an entirely different abbreviation then they can make multiple campaigns like you showed. I don't think abbrev_mp is desirable.

[Discontinuum]

I thought at first hardcoding the "MP" prefix isn't desirable but prolly it makes sense. As you say, people may define two distinct non-hybrid campaigns if they want to