hide_help=yes in [unit_type] hides help halfway

[white-haired-uncle]

Game and System Information

• Version:

Battle for Wesnoth v1.16.10 x86_64
Battle for Wesnoth v1.19.0-dev (ebf93c02bb4-Modified)

• OS:
  Linux spartan 5.15.0-97-generic #107-Ubuntu SMP Wed Feb 7 13:26:48 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Description of the bug

When a [unit_type] has hide_help=yes, the help is hidden if you click on the unit type in the right panel. However, if you just hit 'd', it is not hidden.

Goes back to 1.16 at least.

Steps to reproduce the behavior

Try the above on the "ghost" in the attached.

GUI_Tutorial.tar.gz

Expected behavior

Help hidden in both.

Additional context

No response

[stevecotton]

That pressing 'd' on a unit, or 'ctrl+t' on a hidden terrain, shows the help is by design - as the player can currently see it on screen, they know about it. Seems like a bug in the link-creation in the sidebar.

[white-haired-uncle]

That is a good point. At some point I did think it odd that I could click on one of my units and not know about it. In this case, I should have said that the expected behaviour would be visible in both, or more generally just that they should be consistent.