Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ByteString_slice does not coerce arguments correctly #77

Open
GoogleCodeExporter opened this issue Aug 23, 2015 · 2 comments
Open

ByteString_slice does not coerce arguments correctly #77

GoogleCodeExporter opened this issue Aug 23, 2015 · 2 comments

Comments

@GoogleCodeExporter
Copy link

GCC claims that 'start' and 'end' may be used uninitialized. A quick glance
suggest that it's true.

The "TODO to number" comments pretty much say it all.  Passing anything
other than a number literal into this function will cause it to pass random
addresses to byteThing_fromCArray().

Original issue reported on code.google.com by wes%page...@gtempaccount.com on 20 May 2010 at 8:47

@GoogleCodeExporter
Copy link
Author

Original summary was "Uninitialized variables in ByteString_slice"

Compiler error fixed with

        return gpsee_throw(cx, CLASS_ID ".slice,arguments.0.type: must specify an actual number");

but this is not really the right fix; we should be coercing with 
JS_ValueToNumber.

Original comment by wes%page...@gtempaccount.com on 27 Sep 2010 at 2:25

  • Changed title: * ByteString_slice does not coerce arguments correctly*
  • Added labels: Milestone-Release1.0
  • Removed labels: Milestone-Release0.2

@GoogleCodeExporter
Copy link
Author

Original comment by wes@page.ca on 5 Sep 2012 at 3:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant