Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove abandoned linters, use unused linter #5661

Merged
merged 1 commit into from May 29, 2023
Merged

fix: remove abandoned linters, use unused linter #5661

merged 1 commit into from May 29, 2023

Conversation

diafour
Copy link
Collaborator

@diafour diafour commented May 26, 2023 •
edited

  • Update golangci-lint to 1.52.1 to support Go 1.20 (See go1.20 support golangci/golangci-lint#3414)
  • Remove abandoned linters
  • Add 'nolint' pragmas, should refactor in the future.
  • Enable nolintlint linter.
  • Add max-* settings to show all errors at once.

Abandoned linters gave this warnings:

WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused. 
WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused. 
WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused. 
WARN [linters_context] structcheck is disabled because of generics. You can track the evolution of the generics support by following the https://github.com/golangci/golangci-lint/issues/2649.

@diafour
fix: remove abandoned linters, use unused linter
4d35617 
- Add nolint:unused pragmas.
- Enable nolintlint linter.
- Add max-* settings to show all errors at once.
- update golangci-lint to 1.52.1 to support Go 1.20 (See golangci/golangci-lint#3414)
- ignore some errors, should refactor in the future

Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
@diafour diafour merged commit adbf2c7 into main May 29, 2023
14 checks passed
@diafour diafour deleted the fix_lint_config_cleanup branch May 29, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@diafour