fix(cli): rename ambiguous --skip-build to --require-built-images #5619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diafour
force-pushed
the
fix_rename_skip_build
branch
2 times, most recently
from
478c38c
to
624506d
Compare
- hide skip-build flag, print warning when --skip-build is used Co-authored-by: Aleksei Igrychev <alexey.igrychev@flant.com> Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
diafour
force-pushed
the
fix_rename_skip_build
branch
from
ee8c083
to
134d610
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--skip-buildis ambiguous name, this flag still run steps from the build phase: it checks repositories for images existence, so --require-built-images is more correct name for this flag.