From bc3ac92a1a93eef0f74616fbd54849b623a76f52 Mon Sep 17 00:00:00 2001
From: Timofey Kirillov <timofey.kirillov@flant.com>
Date: Tue, 16 May 2023 19:35:17 +0300
Subject: [PATCH] fix(staged-dockerfile): optimize stages dependencies tree
 builder

Remove doubles of dockerfile-stages which already built in one of the previous images sets.

Signed-off-by: Timofey Kirillov <timofey.kirillov@flant.com>
---
 pkg/build/image/dockerfile.go | 23 +++++++++++++++++++++--
 1 file changed, 21 insertions(+), 2 deletions(-)

diff --git a/pkg/build/image/dockerfile.go b/pkg/build/image/dockerfile.go
index a3713a2600..39ca55833e 100644
--- a/pkg/build/image/dockerfile.go
+++ b/pkg/build/image/dockerfile.go
@@ -91,14 +91,33 @@ func mapDockerfileToImagesSets(ctx context.Context, cfg *dockerfile.Dockerfile,
 
 		appendImageToCurrentSet := func(newImg *Image) {
 			if item.Level == len(ret) {
+				// prepend new images set
+				// ret minimal len is 1 at this moment
 				ret = append([][]*Image{nil}, ret...)
 			}
-			for _, img := range ret[len(ret)-item.Level-1] {
+
+			// find existing same stage in the current images set
+			for _, img := range ret[0] {
 				if img.Name == newImg.Name {
 					return
 				}
 			}
-			ret[len(ret)-item.Level-1] = append(ret[len(ret)-item.Level-1], newImg)
+
+			// exclude same stage from all previous images sets (optimization)
+			for i := 1; i < len(ret); i++ {
+				var newSet []*Image
+				for _, img := range ret[i] {
+					if img.Name != newImg.Name {
+						newSet = append(newSet, img)
+					}
+				}
+				if len(ret[i]) != len(newSet) {
+					// replace previous set only when image was excluded
+					ret[i] = newSet
+				}
+			}
+
+			ret[0] = append(ret[0], newImg)
 		}
 
 		stg := item.Stage