From 5d80460a3bf3d86927dde49535b10eb1a3492c1b Mon Sep 17 00:00:00 2001 From: Timofey Kirillov Date: Mon, 23 May 2022 11:14:17 +0300 Subject: [PATCH] fix(post-renderer): fix null value validation panic in annotations and labels Signed-off-by: Timofey Kirillov --- .../helm/extra_annotations_and_labels_post_renderer.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/pkg/deploy/helm/extra_annotations_and_labels_post_renderer.go b/pkg/deploy/helm/extra_annotations_and_labels_post_renderer.go index c112290edb..6de4249585 100644 --- a/pkg/deploy/helm/extra_annotations_and_labels_post_renderer.go +++ b/pkg/deploy/helm/extra_annotations_and_labels_post_renderer.go @@ -147,7 +147,12 @@ func validateStringNode(node *yaml_v3.Node) error { return fmt.Errorf("unable to decode value %q: %w", node.Value, err) } if _, ok := v.(string); !ok { - return fmt.Errorf("invalid node %q: expected string, got %s", node.Value, reflect.TypeOf(v).String()) + typeOf := reflect.TypeOf(v) + if typeOf != nil { + return fmt.Errorf("invalid node %q: expected string, got %s", node.Value, reflect.TypeOf(v).String()) + } else { + return fmt.Errorf("invalid node %q: expected string, got null value", node.Value) + } } return nil }