Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
feat(config): dependencies directive parser
- Loading branch information
1 parent
9d80598
commit 3eb94e4
Showing
10 changed files
with
322 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,58 @@ | ||
package config | ||
|
||
import ( | ||
"fmt" | ||
"strings" | ||
|
||
"github.com/werf/werf/pkg/util" | ||
) | ||
|
||
type Dependency struct { | ||
ImageName string | ||
Before string | ||
After string | ||
Imports []*DependencyImport | ||
|
||
// TODO: raw *rawDependencies | ||
raw *rawDependency | ||
} | ||
|
||
func (d *Dependency) validate() error { | ||
switch { | ||
case d.ImageName == "": | ||
return newDetailedConfigError("image name is not specified for dependency", d.raw, d.raw.doc()) | ||
case d.Before == "" && d.After == "": | ||
return newDetailedConfigError("dependency stage is not specified with `before: install|setup` or `after: install|setup`", d.raw, d.raw.doc()) | ||
case d.Before != "" && d.After != "": | ||
return newDetailedConfigError("only one dependency stage can be specified with `before: install|setup` or `after: install|setup`, but not both", d.raw, d.raw.doc()) | ||
case d.Before != "" && d.Before != "install" && d.Before != "setup": | ||
return newDetailedConfigError(fmt.Sprintf("invalid dependency stage `before: %s`: expected install or setup!", d.Before), d.raw, d.raw.doc()) | ||
case d.After != "" && d.After != "install" && d.After != "setup": | ||
return newDetailedConfigError(fmt.Sprintf("invalid dependency stage `after: %s`: expected install or setup!", d.After), d.raw, d.raw.doc()) | ||
} | ||
|
||
var targetEnvs, targetBuildArgs []string | ||
for _, depImport := range d.Imports { | ||
if depImport.TargetEnv != "" { | ||
targetEnvs = append(targetEnvs, depImport.TargetEnv) | ||
} | ||
if depImport.TargetBuildArg != "" { | ||
targetBuildArgs = append(targetBuildArgs, depImport.TargetBuildArg) | ||
} | ||
} | ||
|
||
if len(targetEnvs) > 0 { | ||
duplicatedTargetEnvs := util.FindDuplicatedStrings(targetEnvs) | ||
if len(duplicatedTargetEnvs) > 0 { | ||
return newDetailedConfigError(fmt.Sprintf("each targetEnv for dependency import should be unique, but found duplicates for: %s", strings.Join(duplicatedTargetEnvs, ", ")), d.raw, d.raw.doc()) | ||
} | ||
} | ||
|
||
if len(targetBuildArgs) > 0 { | ||
duplicatedTargetBuildArgs := util.FindDuplicatedStrings(targetBuildArgs) | ||
if len(duplicatedTargetBuildArgs) > 0 { | ||
return newDetailedConfigError(fmt.Sprintf("each targetBuildArg for dependency import should be unique, but found duplicates for: %s", strings.Join(duplicatedTargetBuildArgs, ", ")), d.raw, d.raw.doc()) | ||
} | ||
} | ||
|
||
return nil | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,92 @@ | ||
package config | ||
|
||
type dependencyImageType string | ||
|
||
var ( | ||
dependencyImageTypeUnknown dependencyImageType = "" | ||
dependencyImageTypeStapel dependencyImageType = "stapel" | ||
dependencyImageTypeDockerfile dependencyImageType = "dockerfile" | ||
) | ||
|
||
type rawDependency struct { | ||
Image string `yaml:"image,omitempty"` | ||
Before string `yaml:"before,omitempty"` | ||
After string `yaml:"after,omitempty"` | ||
Imports []*rawDependencyImport `yaml:"imports,omitempty"` | ||
|
||
rawStapelImage *rawStapelImage `yaml:"-"` // possible parent | ||
rawImageFromDockerfile *rawImageFromDockerfile `yaml:"-"` // possible parent | ||
|
||
UnsupportedAttributes map[string]interface{} `yaml:",inline"` | ||
} | ||
|
||
func (d *rawDependency) doc() *doc { | ||
var document *doc | ||
switch d.imageType() { | ||
case dependencyImageTypeStapel: | ||
document = d.rawStapelImage.doc | ||
case dependencyImageTypeDockerfile: | ||
document = d.rawImageFromDockerfile.doc | ||
} | ||
|
||
return document | ||
} | ||
|
||
func (d *rawDependency) UnmarshalYAML(unmarshal func(interface{}) error) error { | ||
switch parent := parentStack.Peek().(type) { | ||
case *rawStapelImage: | ||
d.rawStapelImage = parent | ||
case *rawImageFromDockerfile: | ||
d.rawImageFromDockerfile = parent | ||
} | ||
|
||
parentStack.Push(d) | ||
type plain rawDependency | ||
err := unmarshal((*plain)(d)) | ||
parentStack.Pop() | ||
if err != nil { | ||
return err | ||
} | ||
|
||
if err := checkOverflow(d.UnsupportedAttributes, d, d.doc()); err != nil { | ||
return err | ||
} | ||
|
||
return nil | ||
} | ||
|
||
func (d *rawDependency) toDirective() (*Dependency, error) { | ||
dependency := &Dependency{ | ||
ImageName: d.Image, | ||
Before: d.Before, | ||
After: d.After, | ||
raw: d, | ||
} | ||
|
||
for _, rawDepImport := range d.Imports { | ||
depImport, err := rawDepImport.toDirective() | ||
if err != nil { | ||
return nil, err | ||
} | ||
|
||
dependency.Imports = append(dependency.Imports, depImport) | ||
} | ||
|
||
if err := dependency.validate(); err != nil { | ||
return nil, err | ||
} | ||
|
||
return dependency, nil | ||
} | ||
|
||
func (d *rawDependency) imageType() dependencyImageType { | ||
if d.rawStapelImage != nil { | ||
return dependencyImageTypeStapel | ||
} | ||
|
||
if d.rawImageFromDockerfile != nil { | ||
return dependencyImageTypeDockerfile | ||
} | ||
|
||
return dependencyImageTypeUnknown | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
package config | ||
|
||
type rawDependencyImport struct { | ||
Type string `yaml:"type,omitempty"` | ||
TargetBuildArg string `yaml:"targetBuildArg,omitempty"` | ||
TargetEnv string `yaml:"targetEnv,omitempty"` | ||
|
||
rawDependency *rawDependency `yaml:"-"` // parent | ||
|
||
UnsupportedAttributes map[string]interface{} `yaml:",inline"` | ||
} | ||
|
||
func (i *rawDependencyImport) UnmarshalYAML(unmarshal func(interface{}) error) error { | ||
if parent, ok := parentStack.Peek().(*rawDependency); ok { | ||
i.rawDependency = parent | ||
} | ||
|
||
type plain rawDependencyImport | ||
if err := unmarshal((*plain)(i)); err != nil { | ||
return err | ||
} | ||
|
||
if err := checkOverflow(i.UnsupportedAttributes, i, i.rawDependency.doc()); err != nil { | ||
return err | ||
} | ||
|
||
return nil | ||
} | ||
|
||
func (i *rawDependencyImport) toDirective() (*DependencyImport, error) { | ||
depImport := &DependencyImport{ | ||
Type: DependencyImportType(i.Type), | ||
TargetBuildArg: i.TargetBuildArg, | ||
TargetEnv: i.TargetEnv, | ||
raw: i, | ||
} | ||
|
||
if err := depImport.validate(); err != nil { | ||
return nil, err | ||
} | ||
|
||
return depImport, nil | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.