Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text-underline-width #27

Open
lgedeon opened this issue Feb 18, 2015 · 2 comments
Open

text-underline-width #27

lgedeon opened this issue Feb 18, 2015 · 2 comments

Comments

@lgedeon
Copy link

lgedeon commented Feb 18, 2015

In your proposal for CSS4, it was unclear whether you were referring to width on the x or y axis. Since this is a long horizontal line, it is most likely talking about the y-axis.

That said, It would be helpful to have a way to specify left and right margin/padding so that the underline can be extended beyond the text, or start halfway under the first letter.

In the future, it might be worth considering adding a lot of other things that can be done to a rectangle like shadows and such.

@philwareham
Copy link

Also, aren't some of these proposals already in the CSS Text Decoration Module Level 3 proposal? In particular text-decoration-color, text-decoration-skip, text-underline-position.

@wentin
Copy link
Owner

wentin commented Feb 19, 2015

thanks for those feedback! I will think about adding padding margin as an option in underline.js.
And yes, some of the css such as color and skip is already included. though text-underline-position is different than my suggestion. it is left, right, under, mine is where it sits between the baseline and descender line, in px or percentage. also there are underline-stroke-width (I need to rethink about those setting naming, suggestions are welcome!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants