Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standarize django's check messages levels usage #110

Open
skarzi opened this issue Jul 24, 2020 · 2 comments
Open

standarize django's check messages levels usage #110

skarzi opened this issue Jul 24, 2020 · 2 comments

Comments

@skarzi
Copy link
Collaborator

skarzi commented Jul 24, 2020

In #91 we are introducing more Django checks and according to plans this number of checks will grown, so it's time to establish some rules of check messages levels and it's usage.

Django checks messages has following levels (they are similar to logging levels):

  • DEBUG
  • INFO
  • SUCCESS
  • WARNING
  • ERROR

Reference: https://docs.djangoproject.com/en/3.0/topics/checks/#messages

@sobolevn
Copy link
Member

My idea is that:

  • We should issue WARNING messages when there's something not quite right with the app (we found any kind of rule violations)
  • We should issue ERROR messages when our app cannot operate properly

This way user can control their CI level with check --fail-level= command.
By default our warnings would not fail the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants