Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a 2.0 branch? #31

Open
jeroendk opened this issue Oct 20, 2019 · 2 comments
Open

Create a 2.0 branch? #31

jeroendk opened this issue Oct 20, 2019 · 2 comments
Labels

Comments

@jeroendk
Copy link
Contributor

Would you consider creating a 2.0 branch where we can commit (possible) breaking changes?

For example:

  • Change all the public services to private.
  • Add type hint and return types to all methods (where possible).
  • Maybe drop Symfony <3 support because EOL, but only if needed.
@Nightbr
Copy link
Member

Nightbr commented Oct 20, 2019

I prefer we merge the last PR for SF2 and release a last version. And after that we publish a 2.0 & drop php5.6 & SF <3.
I really don't want to maintain 1.x & 2.x version of this lib.

@Nightbr
Copy link
Member

Nightbr commented Jan 31, 2020

Add to that, I would like to drop the support of PHP 5.6 --> in the v2.0 of this bundle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants