-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernizing code & build #102
Comments
@srenauld , thanks very much for the contribution. |
Status update time! Turns out there were a lot more things that could be done, low-hanging fruits and improvements. In particular, I've also put the The branch I've been working on, which is much closer to being a PR candidate, now has the following changes made to it: Indexing:
Search
Storage
Tests A couple of tests were added to cover new components (the new index and DSL) or third-party library support ( My next step is documentation and benchmarks. |
@srenauld How's this effort going? |
@smurrayatwork on this, I've done very little due to a PR being frozen for months. On other fronts, I almost have a plug-in for this library for |
@srenauld, @weixsong - given that this PR is merged, is there anyplace I can look up usage? current docs are out of date. |
@raghur Hello, and sorry about the delay! I'm in the process of working on a side branch for this purpose specifically. The version currently available on The branch I am working on (intermittently, admittedly. I've had a ton of things coming my way recently) is over here. I wired together a small example leveraging the gatsby plugin to both enforce backward-compatibility (wouldn't want to wreck a plugin by accident) and to showcase the use. Regarding the index size, if you are using the new version, I'd be curious to see what you are indexing. This is the kind of feedback that is extremely valuable, as I can change the index format in the new version while still remaining backward-compatible (the old was a straight |
@srenauld - thanks for responding.. No problem at all. TBH, I went through some of your changes and while I absolutely LIKE the features you list, I ran into a few issues (hence the reason I picked master instead of a released version at NPM). Having a working example is great for starters and exactly the thing I was missing picking up master here! Content I'm indexing is from my blog - json is here - https://blog.rraghur.in/index.json. It isn't a large blog by any means and index was coming up to about 4.8MB (Lunr produced 2.3 - 3MB) I think. Also, options like not to storedocuments (I didn't want that on the full text blog content), etc weren't working and I was just running into too much. So finally wrote the comment here and switched back to lunr. I'll try your branch and gatsby example early next week... |
An option like |
As per one of the to-dos, I've started working on modernizing both the code and the build pipeline.
Right now, one of the main drawbacks for contributors (such as myself - one of the issues and PRs I put forward required a partial rewrite due to this) is that the build pipeline relies extensively on
make
, and is effectively a concatenation of all javascript files present inlib/
. This does not provide opportunities to use a modern toolkit (such aswebpack
) to properly "build", nor a testing library likemocha
to operate on a non-built version.The plan of battle, with current status, is as follows:
Makefile
and replace it with awebpack
configuration and associated toolsmocha
(withistanbul
for code coverage)My working branch is over at
code-improvements
on my fork. Once we're back in a stable state, I'll put a PR forward.The text was updated successfully, but these errors were encountered: