FileSink::IsolatedFlush returns false on success

[nickledeg]

The documentation for IsolatedFlush in BufferedTransformation states that IsolatedFlush should return true on success.

The FileSink code returns false on success:

bool FileSink::IsolatedFlush(bool hardFlush, bool blocking)
{
	CRYPTOPP_UNUSED(hardFlush), CRYPTOPP_UNUSED(blocking);
	if (!m_stream)
		throw Err("FileSink: output stream not opened");

	m_stream->flush();
	if (!m_stream->good())
		throw WriteErr();

	return false;
}

The only place where this has a consequence in the library is in FIlter::Flush, where there may be an unintended fallthrough:

bool Filter::Flush(bool hardFlush, int propagation, bool blocking)
{
  switch (m_continueAt)
  {
  case 0:
    if (IsolatedFlush(hardFlush, blocking))
      return true;
    // fall through
  case 1:
    if (OutputFlush(1, hardFlush, propagation, blocking))
      return true;
    // fall through
  default: ;
  }
  return false;
}

[nickledeg]

@maruthiaws, I don't understand your reply. All I see is the code for Filter::Flush which appears to be an exact copy of what I quoted, excluding formatting.