Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar Settings Page ends up weird #53

Open
kraftner opened this issue Nov 16, 2016 · 3 comments
Open

Avatar Settings Page ends up weird #53

kraftner opened this issue Nov 16, 2016 · 3 comments

Comments

@kraftner
Copy link
Member

As we hijack the output of get_avatarthis also affects the output on wp-admin/options-discussion.php showing the same image (the currently logged in users avatar) for all options.

It seems as if the default_avatar_select filter makes it possible to alter the display of those options.

This means we can probably display our own default here or just completely hide these settings. Also see #30 that already covers the default/fallback issue.

@kraftner
Copy link
Member Author

kraftner commented Nov 21, 2016

Completely hiding doesn't seem to be doable as the sentence

For users without a custom avatar of their own, you can either display a generic logo or a generated one based on their email address.

is displayed anyway.

So we have to put something here. Maybe just a notice like

By default the WCM Avatar Plugin displays an empty avatar. If you want to change that use the wcm.avatar.default_avatar avatar filter <a href="{link_to_readme_on_github}">as explained here.

@franz-josef-kaiser
Copy link
Member

@kraftner ehm … what?

as explained here … https://github.com/wecodemore/wcm-avatar/issues/%7Blink_to_readme%7D

@kraftner
Copy link
Member Author

Messed up the formatting. Better now? 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
1.0.0
Backlog
Development

No branches or pull requests

2 participants