Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Plugin work for users without upload_files permission #49

Open
kraftner opened this issue Nov 4, 2016 · 2 comments
Open

Make Plugin work for users without upload_files permission #49

kraftner opened this issue Nov 4, 2016 · 2 comments
Assignees
Projects
Milestone

Comments

@kraftner
Copy link
Member

kraftner commented Nov 4, 2016

Currently the plugin checks for upload_fileseverywhere.
Also when using the multi-uploader everything sits on top of wp-admin/async-upload.php which also checks for this permission.

So to make this work we'd need to find a safe way to enable that. Especially for async-upload.php this also needs to make sure that we only enable the upload for the avatar and not for everything. Maybe something like a nonce (a real one, not a WP nonce).

Also this would probably be the point where we should really have some central helpers to determine these kind of things. See #37.

@kraftner kraftner self-assigned this Nov 16, 2016
@kraftner
Copy link
Member Author

Concerning the multi-uploader the nonce to check this is actually coming from the profile page should probably go somewhere in AvatarRegisterMetaService

@kraftner
Copy link
Member Author

The more I think about this the less I'm sure this should be handled by this plugin, but rather just a section in Readme on how to implement this. Reason is that we'd be messing with upload permissions which is a pretty serious thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
1.0.0
Backlog
Development

No branches or pull requests

1 participant