Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPU code refresh needed: layout parameter now required in createRenderPipeline calls #1602

Open
tidoust opened this issue Mar 24, 2023 · 2 comments
Assignees

Comments

@tidoust
Copy link

tidoust commented Mar 24, 2023

The WebGPU specification (and implementation in Chrome) has evolved slightly since the samples were written. The layout parameter is now required when calling createRenderPipeline or createComputePipeline. Adding layout: 'auto' in calls to createRenderPipeline could be enough to fix that part (unless the code uses a more specific pipeline).

(That said, I think that some of the constructs in WGSL need updating too. I haven't tried to dig into that.)

@fippo
Copy link
Collaborator

fippo commented Mar 31, 2023

@dogben ^

@KubaGluszkiewicz
Copy link

KubaGluszkiewicz commented Jun 20, 2023

since chrome 114 there is more issues with this sample.
I refactored code to make this sample working with newest chrome releases.
Sadly i can't open PR here, so i'm attaching path if anyone interested
0001-refactored-code-to-be-compatible-with-newest-webgpu-.patch

@fippo fyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants