Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scalable Video Codec prevent incorrect Safari usage #1596

Open
4 tasks done
opusonline opened this issue Mar 13, 2023 · 0 comments
Open
4 tasks done

Scalable Video Codec prevent incorrect Safari usage #1596

opusonline opened this issue Mar 13, 2023 · 0 comments
Assignees

Comments

@opusonline
Copy link

opusonline commented Mar 13, 2023

Please read first!

Please use discuss-webrtc for general technical discussions and questions.
If you have found an issue/bug with the native libwebrtc SDK or a browser's behaviour around WebRTC please create an issue in the relevant bug tracker. You can find more information on how to submit a bug and do so in the right place here

  • I understand that issues created here are only relevant to the samples in this repo - not browser or SDK bugs
  • I have provided steps to reproduce
  • I have provided browser name and version
  • I have provided a link to the sample here or a modified version thereof

Note: If the checkboxes above are not checked (which you do after the issue is posted), the issue will be closed.

Browser affected

Browser name including version (e.g. Chrome 64.0.3282.119)
Tested on Safari 15.6.1 and 16.1

Description

Scalable Video Codec sample shows incorrect results on Safari browsers due to Safari's special behaviour with navigator.mediaCapabilities.encodingInfo. Safari reports supported: true and just ignoring the scalabilityMode parameter. Fortunately, Safari includes a supportedConfiguration object within the encodingInfo result, where an additional check can be performed.

if (info.supported && (!info.supportedConfiguration || info.supportedConfiguration.video.scalabilityMode === mode)) {
  // ...
}

Steps to reproduce

Open https://webrtc.github.io/samples/src/content/extensions/svc/ in Safari (>= 15.4), click "Start", allow camera access, select "video/VP8" as Codec preferences.

Expected results

If Safari really supports SVC, only L1T1, L1T2, and L1T3 should be listed. Since Safari doesn't support SVC, the list should be empty.

Actual results

Every single scalability mode is available, even though VP8 should only support L1T1, L1T2, and L1T3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants